clangtidy corrections part 1

lib/Counter/counter.cpp

@@ -1,14 +1,14 @@
 #include "counter.h"
-#include <inttypes.h>
 
 uint8_t Counter::amountOfCounter = 0;
 
-Counter::Counter(uint8_t pin) {
-    this->pulsePin = pin;
-
-    this->unit = static_cast<pcnt_unit_t>(Counter::amountOfCounter);
-    if (Counter::amountOfCounter < 7)
+Counter::Counter(uint8_t pin)
+    : pulsePin{pin}, unit{static_cast<pcnt_unit_t>(Counter::amountOfCounter)}
+{
+    if (Counter::amountOfCounter <= Counter::maxCounter)
+    {
         Counter::amountOfCounter++;
+    }
 
     pcnt_config_t config;
     config.unit = this->unit;
@@ -24,33 +24,40 @@ Counter::Counter(uint8_t pin) {
     pcnt_unit_config(&config);
 }
 
-void Counter::pause() {
+void Counter::pause()
+{
     pcnt_counter_pause(this->unit);
 }
 
-void Counter::resume() {
+void Counter::resume()
+{
     pcnt_counter_resume(this->unit);
 }
 
-void Counter::clear() {
+void Counter::clear()
+{
     pcnt_counter_clear(this->unit);
 }
 
-int16_t Counter::getValue() const {
-    int16_t res;
+int16_t Counter::getValue() const
+{
+    int16_t res = 0;
     pcnt_get_counter_value(this->unit, &res);
     return res;
 }
 
-void Counter::setFilterValue(uint16_t value) {
+void Counter::setFilterValue(uint16_t value)
+{
     pcnt_set_filter_value(this->unit, value);
     this->filterEnable();
 }
 
-void Counter::filterEnable() {
+void Counter::filterEnable()
+{
     pcnt_filter_enable(this->unit);
 }
 
-void Counter::filterDisable() {
+void Counter::filterDisable()
+{
     pcnt_filter_disable(this->unit);
 }

lib/Counter/counter.h

@@ -2,29 +2,32 @@
 
 #include <Arduino.h>
 #include <driver/pcnt.h>
+#include <cinttypes>
 
-class Counter {
-    public:
-        Counter(uint8_t pin);
+class Counter
+{
+public:
+    Counter(uint8_t pin);
 
-        void pause();
-        void resume();
-        void clear();
+    void pause();
+    void resume();
+    void clear();
 
-        int16_t getValue() const;
+    int16_t getValue() const;
 
-        void setFilterValue(uint16_t value);
-        void filterEnable();
-        void filterDisable();
+    void setFilterValue(uint16_t value);
+    void filterEnable();
+    void filterDisable();
 
-    private:
-        static constexpr int16_t highLimit = INT16_MAX;
-        static constexpr uint8_t lowLimit = 0;
+private:
+    static constexpr int16_t highLimit = INT16_MAX;
+    static constexpr uint8_t lowLimit = 0;
+    static constexpr uint8_t maxCounter = 6;
 
-        static uint8_t amountOfCounter;
+    static uint8_t amountOfCounter;
 
-        bool initalised = false;
+    bool initalised = false;
 
-        uint8_t pulsePin;
-        pcnt_unit_t unit;
+    uint8_t pulsePin;
+    pcnt_unit_t unit;
 };