make a lot of things better

lib/Valve/valve.cpp

@@ -1,7 +1,7 @@
 #include "valve.h"
 
-Valve::Valve() {
-    
+Valve::Valve(uint8_t maxOpen) {
+    this->maxOpen = maxOpen;
 }
 
 void Valve::loop() {
@@ -37,6 +37,10 @@ void Valve::open(uint8_t valveNumber, uint8_t minutes) {
     if (valveNumber >= this->valveCount)
         return;
 
+    if (this->getNumOfOpen() >= this->maxOpen) {
+        return;
+    }
+
     this->valves[valveNumber].duration = minutes;
     this->valves[valveNumber].startTime = millis();
     this->setValve(valveNumber, true);
@@ -60,7 +64,7 @@ void Valve::closeAll() {
         this->close(i);
 }
 
-uint8_t Valve::getNumOfOpen() {
+uint8_t Valve::getNumOfOpen() const {
     uint8_t res = 0;
     for (uint8_t i = 0; i < this->valveCount; i++)
         if (this->valves[i].duration)

lib/Valve/valve.h

@@ -13,7 +13,7 @@ class Valve {
             uint32_t startTime;
         };
         
-        Valve();
+        Valve(uint8_t maxOpen);
 
         void loop();
 
@@ -24,7 +24,8 @@ class Valve {
         void close(uint8_t valveNumber);
         void closeAll();
 
-        uint8_t getNumOfOpen();
+        uint8_t getNumOfOpen() const;
+        uint8_t getMaxOpen() const { return this->maxOpen; }
         uint16_t getTimeLeft(uint8_t valveNumber);
 
     private:
@@ -33,6 +34,7 @@ class Valve {
         ShiftRegister* shiftRegister = nullptr;
 
         ValveData valves[MAX_VALVES];
+        uint8_t maxOpen;
         uint8_t valveCount = 0;
         uint16_t loopDelay = 1000;
         uint32_t loopLastMillis = 0;