clangtidy corrections part 2

lib/calibrateCompass/calibrateCompass.cpp

@@ -12,8 +12,8 @@
 #include "calibrateCompass.h"
 
 CalibrateCompass::CalibrateCompass(QMC5883LCompass *compass)
+    : compass{compass}
 {
-    this->compass = compass;
     this->state = State::Ready;
     this->clearData();
     this->activateOnlyChilds();
@@ -29,9 +29,9 @@ void CalibrateCompass::runAsChild()
     bool changed = false;
 
     this->compass->read();
-    int xAxis = this->compass->getX();
-    int yAxis = this->compass->getY();
-    int zAxis = this->compass->getZ();
+    const int xAxis = this->compass->getX();
+    const int yAxis = this->compass->getY();
+    const int zAxis = this->compass->getZ();
 
     if (xAxis < this->data.data[0][0])
     {
@@ -70,7 +70,9 @@ void CalibrateCompass::runAsChild()
     }
 
     if (changed)
+    {
         this->lastChange = millis();
+    }
 
     if (millis() - this->lastChange > this->maxTimeWithoutChange)
     {
@@ -182,23 +184,23 @@ void CalibrateCompass::checkDataValidity()
         sum += this->data.data[i][0];
         sum += this->data.data[i][1];
     }
-    this->dataValid = sum;
+    this->dataValid = static_cast<bool>(sum);
 }
 
-std::ostream &operator<<(std::ostream &os, const CalibrateCompass &caliComp)
+std::ostream &operator<<(std::ostream &stream, const CalibrateCompass &caliComp)
 {
-    os << "(";
-    os << caliComp.data.data[0][0];
-    os << ", ";
-    os << caliComp.data.data[0][1];
-    os << ", ";
-    os << caliComp.data.data[1][0];
-    os << ", ";
-    os << caliComp.data.data[1][1];
-    os << ", ";
-    os << caliComp.data.data[2][0];
-    os << ", ";
-    os << caliComp.data.data[2][1];
-    os << ")";
-    return os;
+    stream << "(";
+    stream << caliComp.data.data[0][0];
+    stream << ", ";
+    stream << caliComp.data.data[0][1];
+    stream << ", ";
+    stream << caliComp.data.data[1][0];
+    stream << ", ";
+    stream << caliComp.data.data[1][1];
+    stream << ", ";
+    stream << caliComp.data.data[2][0];
+    stream << ", ";
+    stream << caliComp.data.data[2][1];
+    stream << ")";
+    return stream;
 }

lib/calibrateCompass/calibrateCompass.h

@@ -1,12 +1,12 @@
 /**
  * @file calibrateCompass.h
  * @author Alexander Klein (alex@kleiax.de)
- * @brief 
+ * @brief
  * @version 0.1
  * @date 2023-05-23
- * 
+ *
  * @copyright Copyright (c) 2023
- * 
+ *
  */
 
 #pragma once
@@ -17,44 +17,47 @@
 
 #include "component.h"
 
-class CalibrateCompass : public Component {
-    public:
-        enum State {
-            Ready,
-            Calibrating,
-            Finished
-        };
+class CalibrateCompass : public Component
+{
+public:
+    enum State
+    {
+        Ready,
+        Calibrating,
+        Finished
+    };
 
-        struct CallibrationData {
-            int data[3][2];
-        };
+    struct CallibrationData
+    {
+        int data[3][2];
+    };
 
-        CalibrateCompass(QMC5883LCompass* compass);
+    CalibrateCompass(QMC5883LCompass *compass);
 
-        void start();
-        void useData();
-        void removeCalibration();
-        void reset();
-        void saveData();
-        void loadData();
+    void start();
+    void useData();
+    void removeCalibration();
+    void reset();
+    void saveData();
+    void loadData();
 
-        State getState() const { return this->state; }
-        CallibrationData getCallibrationData() const { return this->data; }
+    State getState() const { return this->state; }
+    CallibrationData getCallibrationData() const { return this->data; }
 
-        friend std::ostream& operator<<(std::ostream& os, const CalibrateCompass& caliComp);
+    friend std::ostream &operator<<(std::ostream &stream, const CalibrateCompass &caliComp);
 
-    private:
-        void runAsChild() override;
-        void run() override;
-        void checkDataValidity();
+private:
+    void runAsChild() override;
+    void run() override;
+    void checkDataValidity();
 
-        QMC5883LCompass* compass;
-        State state;
-        CallibrationData data;
+    QMC5883LCompass *compass;
+    State state = State::Ready;
+    CallibrationData data{};
 
-        void clearData();
+    void clearData();
 
-        bool dataValid = false;
-        const uint16_t maxTimeWithoutChange = 10000;
-        uint32_t lastChange = 0;
+    bool dataValid = false;
+    const uint16_t maxTimeWithoutChange = 10000;
+    uint32_t lastChange = 0;
 };